linux-kernel - Re: [PATCH 21/22] xfs: %pF is only for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1441051104.4966.41.camel@freescale.com>
Date:	Mon, 31 Aug 2015 14:58:24 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Dave Chinner <david@...morbit.com>, <trivial@...nel.org>,
	<linux-kernel@...r.kernel.org>, <xfs@....sgi.com>
Subject: Re: [PATCH 21/22] xfs: %pF is only for function pointers

On Mon, 2015-08-31 at 15:45 -0400, Steven Rostedt wrote:
> On Mon, 31 Aug 2015 14:24:25 -0500
> Scott Wood <scottwood@...escale.com> wrote:
>  
> > > Can you please look into why this change broke the tracing output
> > > on x86-64 - if there is no obvious/easy fix for it, then I'm simply
> > > going to revert it because having the tracing work correctly on
> > > x86-64 is far more important to us than ppc64 or ia64....
> > 
> > It looks like the cause is that TP_printk() is not really printk() -- it 
> > actually passes the format to userspace which has its own, not 100% 
> > compatible implementation pretty_print() in tools/lib/traceevent/event-
> > parse.c.  %pf in that function behaves like %ps in the kernel, and %ps is 
> > absent.
> > 
> 
> We can fix that with adding %ps to the traceevent library.

I wasn't sure if this would be considered a stable ABI issue, as it's not 
about the events themselves, but about the event mechanism.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/