lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Aug 2015 17:39:08 -0300 From: Arnaldo Carvalho de Melo <acme@...hat.com> To: Wang Nan <wangnan0@...wei.com> Cc: mingo@...nel.org, ast@...mgrid.com, linux-kernel@...r.kernel.org, lizefan@...wei.com, pi3orama@....com, Brendan Gregg <brendan.d.gregg@...il.com>, Daniel Borkmann <daniel@...earbox.net>, David Ahern <dsahern@...il.com>, He Kuang <hekuang@...wei.com>, Jiri Olsa <jolsa@...nel.org>, Kaixu Xia <xiakaixu@...wei.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Namhyung Kim <namhyung@...nel.org>, Paul Mackerras <paulus@...ba.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl> Subject: Re: [PATCH 22/31] perf tools: Add BPF_PROLOGUE config options for further patches Em Sat, Aug 29, 2015 at 04:21:56AM +0000, Wang Nan escreveu: > If both LIBBPF and DWARF are detected, it is possible to create prologue > for eBPF programs to help them accessing kernel data. HAVE_BPF_PROLOGUE > and CONFIG_BPF_PROLOGUE is added as flags for this feature. > > PERF_HAVE_ARCH_GET_REG_OFFSET indicates an architecture supports > converting name of a register to its offset in 'struct pt_regs'. > Without this support, BPF_PROLOGUE should be turned off. > > Signed-off-by: Wang Nan <wangnan0@...wei.com> > Cc: Alexei Starovoitov <ast@...mgrid.com> > Cc: Brendan Gregg <brendan.d.gregg@...il.com> > Cc: Daniel Borkmann <daniel@...earbox.net> > Cc: David Ahern <dsahern@...il.com> > Cc: He Kuang <hekuang@...wei.com> > Cc: Jiri Olsa <jolsa@...nel.org> > Cc: Kaixu Xia <xiakaixu@...wei.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> > Cc: Namhyung Kim <namhyung@...nel.org> > Cc: Paul Mackerras <paulus@...ba.org> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> > Cc: Zefan Li <lizefan@...wei.com> > Cc: pi3orama@....com > Cc: Arnaldo Carvalho de Melo <acme@...hat.com> > Link: http://lkml.kernel.org/n/1436445342-1402-33-git-send-email-wangnan0@huawei.com > --- > tools/perf/config/Makefile | 12 ++++++++++++ > tools/perf/util/include/dwarf-regs.h | 7 +++++++ > 2 files changed, 19 insertions(+) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 38a4144..d46765b7 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -314,6 +314,18 @@ ifndef NO_LIBELF > CFLAGS += -DHAVE_LIBBPF_SUPPORT > $(call detected,CONFIG_LIBBPF) > endif > + > + ifndef NO_DWARF > + ifneq ($(origin PERF_HAVE_ARCH_GET_REG_INFO), undefined) > + CFLAGS += -DHAVE_BPF_PROLOGUE > + $(call detected,CONFIG_BPF_PROLOGUE) > + else > + msg := $(warning BPF prologue is not supported by architecture $(ARCH)); Shouldn't this be replace to something like: msg := $(warning BPF prologue is not supported by architecture $(ARCH), missing ARCH_GET_REG_INFO); Or even in lowercase? > + endif > + else > + msg := $(warning DWARF support is off, BPF prologue is disabled); > + endif > + > endif # NO_LIBBPF > endif # NO_LIBELF > > diff --git a/tools/perf/util/include/dwarf-regs.h b/tools/perf/util/include/dwarf-regs.h > index 8f14965..3dda083 100644 > --- a/tools/perf/util/include/dwarf-regs.h > +++ b/tools/perf/util/include/dwarf-regs.h > @@ -5,4 +5,11 @@ > const char *get_arch_regstr(unsigned int n); > #endif Shouldn't this test against PERF_HAVE_ARCH_GET_REG_INFO instead? I.e. is arch_get_reg_info() only allowed to work with eBPF? I guess not, right? > +#ifdef HAVE_BPF_PROLOGUE > +/* > + * Arch should support fetching the offset of a register in pt_regs > + * by its name. > + */ > +int arch_get_reg_info(const char *name, int *offset); > +#endif > #endif > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists