linux-kernel - Re: [PATCH][resent] PCI: rcar: Add PCIE_CONF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d1y3ggsx.wl%kuninori.morimoto.gx@renesas.com>
Date:	Mon, 31 Aug 2015 23:52:58 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Simon Horman <horms@...ge.net.au>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
	<linux-sh@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	HARUNOBU KUROKAWA <harunobu.kurokawa.dn@...esas.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	NAOYA SHIIBA <naoya.shiiba.nx@...esas.com>,
	TOSHIAKI KOMATSU <toshiaki.komatsu.ud@...esas.com>
Subject: Re: [PATCH][resent] PCI: rcar: Add PCIE_CONF_REGNO macro for PCIECAR register


Hi Simon

Thank you for your feedback

> > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
> > 
> > The reg variable used when setting PCIECAR register need to be masked by 0xFC
> > by restriction of the corresponding register.
> > This adds PCIE_CONF_REGNO are macros for masking changes that PCIE_CONF_REGNO
> > is used when setting PCIECAR register.
> > 
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
> > ---
(snip)
> This seems to partially duplicate the following line earlier on
> in rcar_pcie_config_access().
> 
> 	reg = where & ~3;
> 
> I wonder if that line could be updated to use the new PCIE_CONF_REGNO()
> macro. If so it seems that the second hunk of the patch could be dropped.

We double checked this, and yes, you are correct.
We don't need this patch. Thank you for pointing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/