linux-kernel - Re: [PATCH] mei, make modules.alias UUID information easier to read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E4ECD6.5010006@redhat.com>
Date:	Mon, 31 Aug 2015 20:09:58 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"Kershner, David A" <David.Kershner@...sys.com>,
	Ben Romer <benjamin.romer@...sys.com>
Subject: Re: [PATCH] mei, make modules.alias UUID information easier to read



On 08/29/2015 05:21 PM, Winkler, Tomas wrote:
>>
>> Hi Prarit,
>>
>> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote:
>>> Heikki, Tomas?
>>
>> I'm afraid I don't know much about Intel's Management Engine
>> Interface. Looks like the driver is from Samuel (CC'd) so I'm guessing
>> he is the person you wanted comments from and not me.
>>
> 
> The patch was done against the master branch instead of char-misc-next so it doesn't apply. Anyhow I've rebased it already and I'm testing it. 
> I will probably re-post it, with your permission with my other mei bus fixes.
> 

Yep, only requires some minor adjustments in order to apply to char-misc-next.
Please repost when you can.  FYI: this is needed to bring drivers/staging/unisys
out of the staging directory.

> BTW, I took the inspiration from vmbus in regards to uuid  representation so it if the uuid sting hurts you, you may fix vmbus as well.  I don't have any  vmbus setup and I try not to fix things I cannot check.
> 

I didn't recall other users of add_uuid() but took a look anway.

do_vmbus_entry() doesn't call add_uuid() like do_mei_entry() does.  However,
the vmbus code should also just simply use add_uuid().  I can do that after
this patch gets into the kernel, as it isn't absolutely necessary to fix like
do_mei_entry().  It should be a trivial drivers/hv patch to fix all
that up.

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/