linux-kernel - Re: [PATCH 04/11] fbdev: ssd1307fb: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Sep 2015 13:39:55 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Julia Lawall <Julia.Lawall@...6.fr>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<kernel-janitors@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/11] fbdev: ssd1307fb: fix error return code



On 23/08/15 03:11, Julia Lawall wrote:
> Propagate error code on failure.  Also changed %ld to %d in dev_err to use
> ret variable rather than putting two calls to PTR_ERR.
> 
> A simplified version of the semantic match that finds the first problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/video/fbdev/ssd1307fb.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 3e153c0..1611215 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -656,8 +656,9 @@ static int ssd1307fb_probe(struct i2c_client *client,
>  	bl = backlight_device_register(bl_name, &client->dev, par,
>  				       &ssd1307fb_bl_ops, NULL);
>  	if (IS_ERR(bl)) {
> -		dev_err(&client->dev, "unable to register backlight device: %ld\n",
> -			PTR_ERR(bl));
> +		ret = PTR_ERR(bl);
> +		dev_err(&client->dev, "unable to register backlight device: %d\n",
> +			ret);
>  		goto bl_init_error;
>  	}

Thanks, queued for 4.3.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)