linux-kernel - Re: [PATCH 21/31] perf tools: Move linux/filter.h to tools/include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Sep 2015 05:08:27 +0800
From:	pi3orama <pi3orama@....com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Wang Nan <wangnan0@...wei.com>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"ast@...mgrid.com" <ast@...mgrid.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lizefan@...wei.com" <lizefan@...wei.com>,
	He Kuang <hekuang@...wei.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
	Kaixu Xia <xiakaixu@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 21/31] perf tools: Move linux/filter.h to tools/include



发自我的 iPhone

> 在 2015年9月2日，上午3:39，Arnaldo Carvalho de Melo <acme@...hat.com> 写道：
> 
> Em Sat, Aug 29, 2015 at 04:21:55AM +0000, Wang Nan escreveu:
>> From: He Kuang <hekuang@...wei.com>
>> 
>> This patch moves filter.h from include/linux/kernel.h to
> 
> I said that before: this is not moving anything, it is copying :-)
> 
>> tools/include/linux/filter.h to enable other libraries use macros in
>> it, like libbpf which will be introduced by further patches. Currenty,
>> the moved filter.h only contains the useful macros needed by libbpf
>> for not introducing too much dependence.
>> 
>> MANIFEST is also updated for 'make perf-*-src-pkg'.
> 
> So, I did a:
> 
> $ diff -u include/linux/filter.h tools/include/linux/filter.h
> 
> And noticed these:
> 
> -/* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */
> +/* Endianness conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */
> 
> -/* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */
> +/* Short form of mov based on type,
> + * BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32
> + */
> 
> -/* Conditional jumps against registers, if (dst_reg 'op' src_reg) goto pc + off16 */
> +/* Conditional jumps against registers,
> + * if (dst_reg 'op' src_reg) goto pc + off16
> + */
> 
> -/* Conditional jumps against immediates, if (dst_reg 'op' imm32) goto pc + off16 */
> +/* Conditional jumps against immediates,
> + * if (dst_reg 'op' imm32) goto pc + off16
> + */
> 
> ------------------------------------------------------------------
> 

I think these changes are made after we made this patch.

Thank you for checking it.


> Please refrain from doing that... I.e. spell checking is kinda useful,
> introducing gratuitous further drift from include/linux/FOO.h to
> tools/include/linux/FOO.h is not.
> 
> So either resist the urge to do these stylistic changes or do those changes in
> include/linux/FOO.h and _then_ copy it to tools/include/linux/FOO.h.
> 
> If the copy was already done, fix both, so that when we do that diff again, we
> can see what is really different in kernel and userspace copies and that maybe
> will help us spot things that aren't diverging over time.
> 
> - Arnaldo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/