linux-kernel - Re: [PATCH] phylib: fix device deletion order in mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150901.150304.562643685874217745.davem@davemloft.net>
Date:	Tue, 01 Sep 2015 15:03:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	msalter@...hat.com
Cc:	ddaney.cavm@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, f.fainelli@...il.com,
	buytenh@...tstofly.org, grant.likely@...retlab.ca
Subject: Re: [PATCH] phylib: fix device deletion order in
 mdiobus_unregister()

From: Mark Salter <msalter@...hat.com>
Date: Tue,  1 Sep 2015 09:36:05 -0400

> commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> the bus' parent.") uncovered a problem in mdiobus_unregister() which
> leads to this warning when I reboot an APM Mustang (arm64) platform:
 ...
> The problem is that mdiobus_unregister() deletes the bus device before
> unregistering the phy devices on the bus. This wasn't a problem before
> because the phys were not children of the bus:
> 
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0
> 
> But now that they are:
> 
>   /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03
> 
> when mdiobus_unregister deletes the bus device, the phy subdirs are
> removed from sysfs also. So when the phys are unregistered afterward,
> we get the warning. This patch changes the order so that phys are
> unregistered before the bus device is deleted.
> 
> Signed-off-by: Mark Salter <msalter@...hat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/