linux-kernel - Re: [PATCH V4 3/3] perf,test: test cpu topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150901222952.GB12722@kernel.org>
Date:	Tue, 1 Sep 2015 19:29:52 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Kan Liang <kan.liang@...el.com>
Cc:	jolsa@...nel.org, ak@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 3/3] perf,test: test cpu topology

Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> From: Jiri Olsa <jolsa@...nel.org>
> 
> This patch test cpu core_id and socket_id which are stored in perf_env.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Signed-off-by: Kan Liang <kan.liang@...el.com>
> ---
> 
> Changes since jirka's original version
>  - Use pr_debug to replace fprintf
>  - Add date_size to avoid warning
>  - Introduce cpu_map, and compare core_id and socket_id
>    between cpu_map and perf_env

Humm, two questions:

Since you changed it that much, wouldn't be better to give you the
authorship while still giving credit to Jiri for the original version?
Something like:

Based-on-a-patch-by: Jiri Olsa

[acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
61
[acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
4
[acme@zoo linux]$ 

But then you need to resubmit this anyway, as you forgot to do the:

 git add tools/perf/tests/topology.c

:-)

- Arnaldo
 
> Changes since V2:
>  - unlink(path)
> 
>  tools/perf/tests/Build          | 1 +
>  tools/perf/tests/builtin-test.c | 4 ++++
>  tools/perf/tests/tests.h        | 1 +
>  3 files changed, 6 insertions(+)
> 
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index c1518bd..208bbdf 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -33,6 +33,7 @@ perf-y += parse-no-sample-id-all.o
>  perf-y += kmod-path.o
>  perf-y += thread-map.o
>  perf-y += llvm.o
> +perf-y += topology.o
>  
>  perf-$(CONFIG_X86) += perf-time-to-tsc.o
>  
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 136cd93..6650f26 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -179,6 +179,10 @@ static struct test {
>  		.func = test__llvm,
>  	},
>  	{
> +		.desc = "Test topology in session",
> +		.func = test_session_topology,
> +	},
> +	{
>  		.func = NULL,
>  	},
>  };
> diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> index bf113a2..95654d7 100644
> --- a/tools/perf/tests/tests.h
> +++ b/tools/perf/tests/tests.h
> @@ -63,6 +63,7 @@ int test__fdarray__add(void);
>  int test__kmod_path__parse(void);
>  int test__thread_map(void);
>  int test__llvm(void);
> +int test_session_topology(void);
>  
>  #if defined(__x86_64__) || defined(__i386__) || defined(__arm__) || defined(__aarch64__)
>  #ifdef HAVE_DWARF_UNWIND_SUPPORT
> -- 
> 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/