linux-kernel - Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 01 Sep 2015 15:43:24 -0700
From:	Vasu Dev <vasu.dev@...ux.intel.com>
To:	Vaishali Thakkar <vthakkar1994@...il.com>
Cc:	Vasu Dev <vasu.dev@...el.com>, fcoe-devel@...n-fcoe.org,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of
 __constant_htons to htons

On Wed, 2015-08-19 at 11:18 +0530, Vaishali Thakkar wrote:
> In little endian cases, the macro htons unfolds to __swab16 which
> provides special case for constants. In big endian cases,
> __constant_htons and htons expand directly to the same expression.
> So, replace __constant_htons with htons with the goal of getting
> rid of the definition of __constant_htons completely.
> 
> The semantic patch that performs this transformation is as follows:
> 
> @@expression x;@@
> 
> - __constant_htons(x)
> + htons(x)
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
> ---
>  drivers/scsi/fcoe/fcoe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ec193a8..d3eb80c 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
>  	 * on the ethertype for the given device
>  	 */
>  	fcoe->fcoe_packet_type.func = fcoe_rcv;
> -	fcoe->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE);
> +	fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE);
>  	fcoe->fcoe_packet_type.dev = netdev;
>  	dev_add_pack(&fcoe->fcoe_packet_type);
>  

Acked-by: Vasu Dev <vasu.dev@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/