linux-kernel - RE: [PATCH V7 2/3] qe_common: add qe_muram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR0301MB1550486CECE45995C54272089B690@SN1PR0301MB1550.namprd03.prod.outlook.com>
Date:	Wed, 2 Sep 2015 02:32:14 +0000
From:	Zhao Qiang <qiang.zhao@...escale.com>
To:	Scott Wood <scottwood@...escale.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"lauraa@...eaurora.org" <lauraa@...eaurora.org>,
	Xiaobo Xie <X.Xie@...escale.com>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
	Li Leo <LeoLi@...escale.com>,
	"paulus@...ba.org" <paulus@...ba.org>
Subject: RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram

On Wed, 2015-09-02 at 10:31AM, Wood Scott-B07421 wrote:
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 10:31 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> lauraa@...eaurora.org; Xie Xiaobo-R63061; benh@...nel.crashing.org; Li
> Yang-Leo-R58472; paulus@...ba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
> 
> On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> > On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Wednesday, September 02, 2015 8:34 AM
> > > To: Zhao Qiang-B45475
> > > Cc: linux-kernel@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> > > lauraa@...eaurora.org; Xie Xiaobo-R63061; benh@...nel.crashing.org;
> > > Li Yang-Leo-R58472; paulus@...ba.org
> > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> > >
> > > > -int cpm_muram_init(void)
> > > > -{
> > > > -     struct device_node *np;
> > > > -     struct resource r;
> > > > -     u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > > -     resource_size_t max = 0;
> > > > -     int i = 0;
> > > > -     int ret = 0;
> > > > -
> > > > -     if (muram_pbase)
> > > > -             return 0;
> > > > -
> > > > -     spin_lock_init(&cpm_muram_lock);
> > > > -     /* initialize the info header */
> > > > -     rh_init(&cpm_muram_info, 1,
> > > > -             sizeof(cpm_boot_muram_rh_block) /
> > > > -             sizeof(cpm_boot_muram_rh_block[0]),
> > > > -             cpm_boot_muram_rh_block);
> > > > -
> > > > -     np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-
> data");
> > > > -     if (!np) {
> > > > -             /* try legacy bindings */
> > > > -             np = of_find_node_by_name(NULL, "data-only");
> > > > -             if (!np) {
> > > > -                     printk(KERN_ERR "Cannot find CPM muram data
> > > node");
> > > > -                     ret = -ENODEV;
> > > > -                     goto out;
> > > > -             }
> > > > -     }
> > > > -
> > > > -     muram_pbase = of_translate_address(np, zero);
> > > > -     if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > > -             printk(KERN_ERR "Cannot translate zero through CPM
> muram
> > > node");
> > > > -             ret = -ENODEV;
> > > > -             goto out;
> > > > -     }
> > >
> > > Did you pass -M -C to git format-patch?
> >
> >
> > Yes!
> 
> Then maybe it's the qe/cpm rename churn, or similar, that prevented it
> from being identified as a move?

Maybe

> 
> -Scott
-Zhao