linux-kernel - [PATCH] irqchip/gicv3-its: comfort build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1441170974-5547-1-git-send-email-alex.shi@linaro.org>
Date:	Wed,  2 Sep 2015 13:16:14 +0800
From:	Alex Shi <alex.shi@...aro.org>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Marc Zyngier <marc.zyngier@....com>,
	linux-kernel@...r.kernel.org (open list:IRQCHIP DRIVERS)
Cc:	Alex Shi <alex.shi@...aro.org>
Subject: [PATCH] irqchip/gicv3-its: comfort build warnings

There are some warnings in gicv3-its.
It looks like they are set in its_lpi_alloc_chunks(), but
in fact, both of them(lpi_base/nr_lpis) still have some chances
as unset variables. Anyway to comfort gcc if it's not a issue.

drivers/irqchip/irq-gic-v3-its.c: In function ‘its_msi_prepare’:
drivers/irqchip/irq-gic-v3-its.c:1148:26: warning: ‘lpi_base’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  dev->event_map.lpi_base = lpi_base;
                          ^
drivers/irqchip/irq-gic-v3-its.c:1116:6: note: ‘lpi_base’ was declared here
  int lpi_base;
      ^
drivers/irqchip/irq-gic-v3-its.c:1149:25: warning: ‘nr_lpis’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  dev->event_map.nr_lpis = nr_lpis;
                         ^
drivers/irqchip/irq-gic-v3-its.c:1117:6: note: ‘nr_lpis’ was declared here
  int nr_lpis;
      ^

Signed-off-by: Alex Shi <alex.shi@...aro.org>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: Jason Cooper <jason@...edaemon.net>
---
 drivers/irqchip/irq-gic-v3-its.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 26b55c5..0f0af18 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -1113,8 +1113,8 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id,
 	unsigned long flags;
 	u16 *col_map = NULL;
 	void *itt;
-	int lpi_base;
-	int nr_lpis;
+	int lpi_base = 0;
+	int nr_lpis = 0;
 	int nr_ites;
 	int sz;
 
-- 
2.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/