linux-kernel - Re: [PATCH V4 3/3] perf,test: test cpu topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150902060308.GD1978@krava.brq.redhat.com>
Date:	Wed, 2 Sep 2015 08:03:08 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Liang, Kan" <kan.liang@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 3/3] perf,test: test cpu topology

On Tue, Sep 01, 2015 at 11:25:10PM +0000, Liang, Kan wrote:
> 
> 
> > 
> > Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> > > From: Jiri Olsa <jolsa@...nel.org>
> > >
> > > This patch test cpu core_id and socket_id which are stored in perf_env.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > > Signed-off-by: Kan Liang <kan.liang@...el.com>
> > > ---
> > >
> > > Changes since jirka's original version
> > >  - Use pr_debug to replace fprintf
> > >  - Add date_size to avoid warning
> > >  - Introduce cpu_map, and compare core_id and socket_id
> > >    between cpu_map and perf_env
> > 
> > Humm, two questions:
> > 
> > Since you changed it that much, wouldn't be better to give you the
> > authorship while still giving credit to Jiri for the original version?
> > Something like:
> > 
> > Based-on-a-patch-by: Jiri Olsa
> 
> Jiri, are you OK with that?

yep

> 
> > 
> > [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
> > 61
> > [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
> > 4
> > [acme@zoo linux]$
> > 
> > But then you need to resubmit this anyway, as you forgot to do the:
> > 
> >  git add tools/perf/tests/topology.c
> 
> Ah... My bad. :(
> 
> I will resubmit the patch then.

I'll review new version

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/