linux-kernel - Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55E6E8AA.6070108@cogentembedded.com>
Date:	Wed, 02 Sep 2015 15:16:42 +0300
From:	Vladimir Barinov <vladimir.barinov@...entembedded.com>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Daniel Baluta <daniel.baluta@...el.com>, jic23@...nel.org,
	jlbec@...lplan.org, linux-iio@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
CC:	knaack.h@....de, linux-kernel@...r.kernel.org,
	octavian.purdila@...el.com, pebolle@...cali.nl,
	patrick.porlan@...el.com, adriana.reus@...el.com,
	constantin.musca@...el.com, marten@...uitiveaerial.com,
	cristina.opriceana@...il.com, pmeerw@...erw.net, hch@....de,
	viro@...iv.linux.org.uk, akpm@...ux-foundation.org
Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

Hi Lars,

On 31.08.2015 17:57, Lars-Peter Clausen wrote:
> On 08/17/2015 02:45 PM, Vladimir Barinov wrote:
>> Hello Daniel,
>>
>> I've verified that your hrtimer trigger works.
>>
>> I have minor suggestions.
>>
>> Will not it be useful to have ability to stop/start hrtimer polling
>> not only during attach/detach trigger.
>>
>> f.e. writing 0 to sampling_frequency will hrtimer_cancel
>> and writing any valid frequency will hrtimer_start.
> What's the use case for this?
Setting sampling frequency to 0 Hz.

I do agree that 0Hz is meaningless and the same effect
is achieved by removing trigger from iio device,
but having 0 Hz frequency could probably be more consecutive
for this trigger instead of returning EINVAL.

Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/