| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1441200891.17400.1277.camel@localhost.localdomain> Date: Wed, 02 Sep 2015 14:34:51 +0100 From: Roger Willcocks <roger@...mlight.ltd.uk> To: Stephen Rothwell <sfr@...b.auug.org.au> Cc: Jens Axboe <axboe@...nel.dk>, David Jeffery <djeffery@...hat.com>, linux-kernel@...r.kernel.org, xfs@....sgi.com, Ben Myers <bpm@....com>, linux-next@...r.kernel.org, Christoph Hellwig <hch@....de> Subject: Re: linux-next: manual merge of the block tree with the xfs tree On Wed, 2015-09-02 at 23:03 +1000, Stephen Rothwell wrote: > Hi Roger, > > On Wed, 2 Sep 2015 10:45:29 +0100 Roger Willcocks <roger@...mlight.ltd.uk> wrote: > > > > On 2 Sep 2015, at 03:16, Stephen Rothwell <sfr@...b.auug.org.au> wrote: > > > > > ++ if (!ioend->io_error) > > > ++ ioend->io_error = bio->bi_error; > > > > This is incorrect; it can clear an earlier error status. It should probably read: > > > > if (!ioend->io_error && bio->bi_error) > > ioend->io_error = bio->bi_error; > > Thanks, I will use that from tomorrow. > Huh, now I've had my coffee, that extra check doesn't add anything. (There's no harm done in assigning zero to io_error if it's already zero.) Apologies for the noise. -- Roger Willcocks <roger@...mlight.ltd.uk> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists