[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1509021138200.32729@vincent-weaver-1.umelst.maine.edu>
Date: Wed, 2 Sep 2015 11:40:40 -0400 (EDT)
From: Vince Weaver <vincent.weaver@...ne.edu>
To: Vince Weaver <vincent.weaver@...ne.edu>
cc: linux-kernel@...r.kernel.org,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: perf: possible bug in perf_event__read_size
On Wed, 2 Sep 2015, Vince Weaver wrote:
> Shouldn't that be
>
> if (event->attr.read_format & PERF_FORMAT_ID)
> size += sizeof(u64);
never mind, after a lot of further thought I can see this is a "clever"
hack to allow group events to have an ID for each value.
It's a shame the perf_event code doesn't more comments in the code,
especially when the code is being clever like this.
Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists