linux-kernel - Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANAwSgSWnFFY3apBv9HY8XM2zEJs3N5vLfQaNxM=5f+qNs5bhw@mail.gmail.com>
Date:	Wed, 2 Sep 2015 21:10:03 +0530
From:	Anand Moon <linux.amoon@...il.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Andreas Faerber <afaerber@...e.de>,
	Sachin Kamat <sachin.kamat@...sung.com>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3

HI Krzysztof,

On 2 September 2015 at 19:42, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:
> W dniu 08.06.2015 o 02:03, Anand Moon pisze:
>> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for
>> Odroid-XU3 board.
>>
>> Signed-off-by: Anand Moon <linux.amoon@...il.com>
>
> Dear Anand,
>
> There was some confusion for this patch (mixed v3 and v2) so overall it
> slipped through fingers.
>
> Can you please:
> 1. Rebase and resend.
> 2. Enable them as built-ins, not modules. For exynos_defconfig
> everything is built-in which makes easier to test on various boards.
> 3. Enable LEDS_GPIO. I don't know why it disappeared...
>
> Best regards,
> Krzysztof
>
>
>> ---
>>  arch/arm/configs/exynos_defconfig | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>> index 1b7253b..2bbdf80 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
>>  CONFIG_MMC_DW=y
>>  CONFIG_MMC_DW_IDMAC=y
>>  CONFIG_MMC_DW_EXYNOS=y
>> +CONFIG_NEW_LEDS=y
>> +CONFIG_LEDS_CLASS=m
>> +CONFIG_LEDS_PWM=m
>> +CONFIG_LEDS_TRIGGERS=y
>> +CONFIG_LEDS_TRIGGER_TIMER=m
>> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m
>>  CONFIG_RTC_CLASS=y
>>  CONFIG_RTC_DRV_MAX77686=y
>>  CONFIG_RTC_DRV_MAX77802=y
>>
>

Thanks for you input I will resend this patch.

-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/