linux-kernel - Re: [PATCH v17 3/4] soc: rockchip: power-domain: Add power domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hbndkptfm.fsf@linaro.org>
Date:	Wed, 02 Sep 2015 11:28:13 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	heiko@...ech.de, ulf.hansson@...aro.org,
	devicetree@...r.kernel.org, linux@....linux.org.uk, arnd@...db.de,
	ijc+devicetree@...lion.org.uk, linux-kernel@...r.kernel.org,
	linus.walleij@...aro.org, dmitry.torokhov@...il.com,
	dianders@...omium.org, tomasz.figa@...il.com,
	linux-rockchip@...ts.infradead.org, robh+dt@...nel.org,
	galak@...eaurora.org, linux-arm-kernel@...ts.infradead.org,
	mturquette@...libre.com, "jinkun.hong" <jinkun.hong@...k-chips.com>
Subject: Re: [PATCH v17 3/4] soc: rockchip: power-domain: Add power domain driver

Caesar Wang <wxt@...k-chips.com> writes:

> This driver is found on RK3288 SoCs.
>
> In order to meet high performance and low power requirements, a power
> management unit is designed or saving power when RK3288 in low power
> mode.
> The RK3288 PMU is dedicated for managing the power of the whole chip.
>
> PMU can work in the Low Power Mode by setting bit[0] of PMU_PWRMODE_CON
> register. After setting the register, PMU would enter the Low Power mode.
> In the low power mode, pmu will auto power on/off the specified power
> domain, send idle req to specified power domain, shut down/up pll and
> so on. All of above are configurable by setting corresponding registers.
>
> Signed-off-by: jinkun.hong <jinkun.hong@...k-chips.com>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>

[...]

> +static void rockchip_pm_remove_one_domain(struct rockchip_pm_domain *pd)
> +{
> +	int i;
> +
> +	for (i = 0; i < pd->num_clks; i++) {
> +		clk_unprepare(pd->clks[i]);
> +		clk_put(pd->clks[i]);
> +	}


You don't set pd->num_clks = 0 here, which means other places that
iterate over the clocks might race with this and try to use clocks that
have been unprepared/put.

This might be over-paranoid, but in particular, this could race with
rockchip_pd_power().

Also not setting the pd->num_clks to zero would be a problem for a
power-controller that is configured as a module which could be unloaded
and reloaded (I know that doesn't really work now, but it will
eventually, I hope.)

Maybe use the mutex here?  It should at least protect the zeroing of
pm->num_clks.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/