linux-kernel - Re: [PATCH] ARM: dts: rk3288: pull up cts lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WEc4tSn7HhFkVWRJwb7Z33Kq4u3ubsYKb2xyJLAQrVPg@mail.gmail.com>
Date:	Wed, 2 Sep 2015 15:57:30 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Alexandru M Stan <amstan@...omium.org>
Cc:	Heiko Stuebner <heiko@...ech.de>,
	Jeffy Chen <jeffy.chen@...k-chips.com>,
	Caesar Wang <wxt@...k-chips.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Neil Hendin <nhendin@...omium.org>
Subject: Re: [PATCH] ARM: dts: rk3288: pull up cts lines

Alex,

On Wed, Sep 2, 2015 at 3:20 PM, Alexandru M Stan <amstan@...omium.org> wrote:
> The flow control lines from a user accessible UART are optional,
> the user might not have anything connected to those pins.
> In order to prevent random interrupts happening and noise affecting
> that pin it should be pulled up.
>
> Note that the default state for those pins on the rk3288 is pulled up,
> so this patch merely restores them.
>
> Suggested-by: Neil Hendin <nhendin@...omium.org>
> Signed-off-by: Alexandru M Stan <amstan@...omium.org>
> ---
>  arch/arm/boot/dts/rk3288.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 906e938..a059367 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1211,11 +1211,11 @@
>                         };
>
>                         uart0_cts: uart0-cts {
> -                               rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_none>;
> +                               rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_up>;
>                         };
>
>                         uart0_rts: uart0-rts {
> -                               rockchip,pins = <4 19 RK_FUNC_1 &pcfg_pull_none>;
> +                               rockchip,pins = <4 19 RK_FUNC_1 &pcfg_pull_up>;

I would probably do just CTS.  That would match the TX / RX lines
where the RX is pulled but not the TX.

You might also mention in the commit message that this really should
be safe since we're already doing something similar for RX.


-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/