lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 02 Sep 2015 16:27:18 -0700 (PDT) From: David Miller <davem@...emloft.net> To: kolmakov.dmitriy@...wei.com Cc: jon.maloy@...csson.com, ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] tipc: fix stall during bclink wakeup procedure From: Kolmakov Dmitriy <kolmakov.dmitriy@...wei.com> Date: Wed, 2 Sep 2015 15:33:00 +0000 > If an attempt to wake up users of broadcast link is made when there > is no enough place in send queue than it may hang up inside the > tipc_sk_rcv() function since the loop breaks only after the wake up > queue becomes empty. This can lead to complete CPU stall with the > following message generated by RCU: I don't understand how it can loop forever. It should either successfully deliver each packet to the socket, or respond with a TIPC_ERR_OVERLOAD. In both cases, the SKB is dequeued from the queue and forward progress is made. If there really is a problem somewhere in here, then two things: 1) You need to describe exactly the sequence of tests and conditions that lead to the endless loop in this code, because I cannot see it. 2) I suspect the fix is more likely to be appropriate in tipc_sk_rcv() or similar, rather than creating a dummy queue to workaround it's behavior. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists