linux-kernel - Re: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XRLnz3FTbwg1u2Jwg=a3dim6vwLk0yGc9kK=RGYDvxXw@mail.gmail.com>
Date:	Wed, 2 Sep 2015 16:34:38 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Alexandru M Stan <amstan@...omium.org>
Cc:	Heiko Stuebner <heiko@...ech.de>,
	Romain Perier <romain.perier@...il.com>,
	FUKAUMI Naoki <naobsd@...il.com>,
	Neil Hendin <nhendin@...omium.org>,
	Jeffy Chen <jeffy.chen@...k-chips.com>,
	Caesar Wang <wxt@...k-chips.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288

Alex,

On Wed, Sep 2, 2015 at 4:27 PM, Alexandru M Stan <amstan@...omium.org> wrote:
> The flow control lines from a user accessible UART are optional,
> the user might not have anything connected to those pins.
> In order to prevent random interrupts happening and noise affecting
> the cts pin should be pulled up.
>
> Note that the default state for that pin on the rk3288 is pulled up,
> so this patch merely restores them.
>
> This is similar to what we're already doing with the RX pin,
> so it should be safe. At worst it might be a slightly higher power usage
> (through ~50 kohms) when the cts is low.
>
> Suggested-by: Neil Hendin <nhendin@...omium.org>
> Signed-off-by: Alexandru M Stan <amstan@...omium.org>
> ---
> Changes in v2: None

Probably not entirely true.  ;)

>  arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Looks good to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/