linux-kernel - Re: [PATCH] null_blk: fix memory leak on cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55E7DF32.1080805@bjorling.me>
Date:	Thu, 3 Sep 2015 07:48:34 +0200
From:	Matias Bjorling <m@...rling.me>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>, axboe@...com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Matias Bjørling <mb@...htnvm.io>
Subject: Re: [PATCH] null_blk: fix memory leak on cleanup

Den 02-09-2015 kl. 20:39 skrev Ross Zwisler:
> On Mon, Aug 31, 2015 at 02:17:18PM +0200, Matias Bjørling wrote:
>> From: Matias Bjørling <mb@...htnvm.io>
>>
>> Driver was not freeing the memory allocated for internal nullb queues.
>> This patch frees the memory during driver unload.
>
> You may want to consider devm_* style allocations instead.  These are freed
> automatically on driver unload, simplifying your error paths and your unload
> logic as well as preventing leaks.
>
> See this patch for an example:
>
> https://lkml.org/lkml/2015/8/10/992
>

Thanks for looking through the patches. I'll look into it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/