linux-kernel - Re: [PATCH v6 2/3] KVM: dynamic halt_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLU437-SMTP22940A9EED1ACEFD68F3EF80680@phx.gbl>
Date:	Thu, 3 Sep 2015 16:52:01 +0800
From:	Wanpeng Li <wanpeng.li@...mail.com>
To:	Paolo Bonzini <pbonzini@...hat.com>,
	David Matlack <dmatlack@...gle.com>
CC:	kvm list <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment

On 9/3/15 3:31 PM, Paolo Bonzini wrote:
>
> On 02/09/2015 21:23, David Matlack wrote:
>> I actually wasn't thinking about vcpu->halt_poll_ns though. If
>> single_task_running() breaks us out of the loop we will "goto out" instead
>> of scheduling. My suspicion is this will cause us to loop calling
>> kvm_vcpu_block and starve the waiting task (at least until need_resched()),
>> which would break the "only hog the cpu when idle" aspect of halt-polling.
> That's definitely a bug, yes.

Ok, I will send out v7 to fix this in this sunday since there is 
vacation in my country currently.

Regards,
Wanpeng Li

>
> Paolo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/