linux-kernel - Re: [PATCH v2 2/4] perf tests: make objdump disassemble zero blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E80EBA.6080107@intel.com>
Date:	Thu, 3 Sep 2015 12:11:22 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Jan Stancek <jstancek@...hat.com>
Cc:	linux-kernel@...r.kernel.org, acme@...nel.org, jolsa@...nel.org,
	dsahern@...il.com, cjashfor@...ux.vnet.ibm.com, fweisbec@...il.com,
	mingo@...nel.org, namhyung@...nel.org, paulus@...ba.org,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH v2 2/4] perf tests: make objdump disassemble zero blocks

On 02/09/15 11:19, Jan Stancek wrote:
> Add -z parameter to avoid skipping zero blocks:
> 
>  ffffffff816704fe <sysret_check+0x4b>:
>  ffffffff816704fe:  7b 34         jnp ffffffff81670534 <sysret_signal+0x1c>
>        ...
>  ffffffff81670501 <sysret_careful>:
>  ffffffff81670501:  0f ba e2 03   bt  $0x3,%edx
>  ffffffff81670505:  73 11         jae ffffffff81670518 <sysret_signal>
> 
> Signed-off-by: Jan Stancek <jstancek@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Apart from nitpick below:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  tools/perf/tests/code-reading.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
> index 38ee90bc2228..375ba30e4ed0 100644
> --- a/tools/perf/tests/code-reading.c
> +++ b/tools/perf/tests/code-reading.c
> @@ -128,7 +128,8 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf,
>  	FILE *f;
>  	int ret;
>  
> -	fmt = "%s -d --start-address=0x%"PRIx64" --stop-address=0x%"PRIx64" %s";
> +	fmt = "%s -z -d --start-address=0x%"PRIx64\

The line continuation is not needed but we are not that religious about long
lines especially if they contain string literals, so you could just make it
one line.

> +		" --stop-address=0x%"PRIx64" %s";
>  	ret = snprintf(cmd, sizeof(cmd), fmt, "objdump", addr, addr + len,
>  		       filename);
>  	if (ret <= 0 || (size_t)ret >= sizeof(cmd))
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/