linux-kernel - Re: [PATCH v2 4/4] perf tests: print objdump/dso buffers if they don't match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E80F15.7000304@intel.com>
Date:	Thu, 3 Sep 2015 12:12:53 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Jan Stancek <jstancek@...hat.com>
Cc:	linux-kernel@...r.kernel.org, acme@...nel.org, jolsa@...nel.org,
	dsahern@...il.com, cjashfor@...ux.vnet.ibm.com, fweisbec@...il.com,
	mingo@...nel.org, namhyung@...nel.org, paulus@...ba.org,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH v2 4/4] perf tests: print objdump/dso buffers if they
 don't match

On 02/09/15 11:19, Jan Stancek wrote:
> Signed-off-by: Jan Stancek <jstancek@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>


Acked-by: Adrian Hunter <adrian.hunter@...el.com>


> ---
>  tools/perf/tests/code-reading.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
> index e6bf47ff7e91..53a04f899d18 100644
> --- a/tools/perf/tests/code-reading.c
> +++ b/tools/perf/tests/code-reading.c
> @@ -163,6 +163,18 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf,
>  	return ret;
>  }
>  
> +static void dump_buf(unsigned char *buf, size_t len)
> +{
> +	size_t i;
> +
> +	for (i = 0; i < len; i++) {
> +		pr_debug("0x%02x ", buf[i]);
> +		if (i % 16 == 15)
> +			pr_debug("\n");
> +	}
> +	pr_debug("\n");
> +}
> +
>  static int read_object_code(u64 addr, size_t len, u8 cpumode,
>  			    struct thread *thread, struct state *state)
>  {
> @@ -265,6 +277,10 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,
>  	/* The results should be identical */
>  	if (memcmp(buf1, buf2, len)) {
>  		pr_debug("Bytes read differ from those read by objdump\n");
> +		pr_debug("buf1 (dso):\n");
> +		dump_buf(buf1, len);
> +		pr_debug("buf2 (objdump):\n");
> +		dump_buf(buf2, len);
>  		return -1;
>  	}
>  	pr_debug("Bytes read match those read by objdump\n");
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/