linux-kernel - Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on init or probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Sep 2015 13:45:50 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	Julia Lawall <julia.lawall@...6.fr>
Cc:	Alessandro Rubini <rubini@...dd.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	David Woodhouse <dwmw2@...radead.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jie Yang <yang.jie@...el.com>, Jiri Slaby <jslaby@...e.com>,
	Jonathan Corbet <corbet@....net>,
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	Kay Sievers <kay@...y.org>,
	Kevin Cernekee <cernekee@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michal Marek <mmarek@...e.com>,
	Ming Lei <ming.lei@...onical.com>,
	Takashi Iwai <tiwai@...e.de>, Tom Gundersen <teg@...m.no>,
	Yalin Wang <yalin.wang2010@...il.com>,
	Coccinelle <cocci@...teme.lip6.fr>, linux-doc@...r.kernel.org,
	linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on
 init or probe

> +@ calls_fw_on_init depends on defines_module_init @
> +identifier defines_module_init.init;
> +position p1;
> +@@
> +
> +init(void)
> +{
> + ...

Would it make sense to use the specification "when any"
for such a SmPL ellipsis?
http://coccinelle.lip6.fr/docs/main_grammar004.html


> +(
> +request_firmware@p1(...)
> +|
> +request_firmware_nowait@p1(...)
> +|
> +request_firmware_direct@p1(...)
> +)
> +...
> +}


Are there any more source code variants to check today?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/