linux-kernel - Re: [RFC PATCH 9/9] parisc: allocate sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Sep 2015 14:26:10 +0200
From:	"Helge Deller" <deller@....de>
To:	"Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	linux-parisc@...r.kernel.org
Subject: Re: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call
 number

Hi Mathieu,

> [ Untested on this architecture. To try it out: fetch linux-next/akpm,
>   apply this patch, build/run a membarrier-enabled kernel, and do make
>   kselftest. ]
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: linux-api@...r.kernel.org
> CC: "James E.J. Bottomley" <jejb@...isc-linux.org>
> CC: Helge Deller <deller@....de>
> CC: linux-parisc@...r.kernel.org
> ---
>  arch/parisc/include/uapi/asm/unistd.h | 3 ++-
>  arch/parisc/kernel/syscall_table.S    | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h
> index 2e639d7..dadcada 100644
> --- a/arch/parisc/include/uapi/asm/unistd.h
> +++ b/arch/parisc/include/uapi/asm/unistd.h
> @@ -358,8 +358,9 @@
>  #define __NR_memfd_create	(__NR_Linux + 340)
>  #define __NR_bpf		(__NR_Linux + 341)
>  #define __NR_execveat		(__NR_Linux + 342)
> +#define __NR_membarrier		(__NR_Linux + 343)
>  
> -#define __NR_Linux_syscalls	(__NR_execveat + 1)
> +#define __NR_Linux_syscalls	(__NR_membarrier + 1)
>  
>  
>  #define __IGNORE_select		/* newselect */
> diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
> index 8eefb12..2faa43b 100644
> --- a/arch/parisc/kernel/syscall_table.S
> +++ b/arch/parisc/kernel/syscall_table.S
> @@ -438,6 +438,7 @@
>  	ENTRY_SAME(memfd_create)	/* 340 */
>  	ENTRY_SAME(bpf)
>  	ENTRY_COMP(execveat)
> +	ENTRY_COMP(membarrier)

This needs to be ENTRY_SAME(membarrier), since you don't have/need a compat_membarrier() function.

After changing to ENTRY_SAME() I did run the kselftest on parisc: 
deller@...xx> ./membarrier_test 
membarrier MEMBARRIER_CMD_QUERY syscall available.
membarrier: MEMBARRIER_CMD_SHARED success.
membarrier: tests done!

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/