linux-kernel - Re: [PATCH] drivers:staging:vt6655: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Sep 2015 18:01:38 -0700
From:	Greg KH <greg@...ah.com>
To:	lysanovsergey@...il.com
Cc:	forest@...ttletooquiet.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:vt6655: Fix coding style issues

On Fri, Aug 28, 2015 at 01:51:44PM +0300, lysanovsergey@...il.com wrote:
> From: Sergey Lysanov <lysanovsergey@...il.com>
> 
> This patch fixes the following issues reported by checkpatch.pl:
> - code indent should use tabs where possible
> - space prohibited before that ','
> 
> Signed-off-by: Sergey Lysanov <lysanovsergey@...il.com>
> ---
>  drivers/staging/vt6655/rxtx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 5875d65..64957de 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -64,8 +64,8 @@
>  /*---------------------  Static Functions  --------------------------*/
>  
>  /*---------------------  Static Definitions -------------------------*/
> -#define CRITICAL_PACKET_LEN      256    /* if packet size < 256 -> in-direct send
> -                                            packet size >= 256 -> direct send */
> +#define CRITICAL_PACKET_LEN	256 /* if packet size < 256 -> in-direct send
> +				     packet size >= 256 -> direct send */
>  
>  static const unsigned short wTimeStampOff[2][MAX_RATE] = {
>  	{384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
>  };
>  static const unsigned short wFB_Opt1[2][5] = {
>  	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> +	{RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */

The goal was to keep these aligned, which you broke the formatting for
:(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/