linux-kernel - Re: [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55E86624.4000403@roeck-us.net>
Date:	Thu, 03 Sep 2015 08:24:20 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	linux-kernel@...r.kernel.org
CC:	Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF
 platform driver

On 09/03/2015 04:06 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/moxart_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2789da2..60b0605 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -168,6 +168,7 @@ static const struct of_device_id moxart_watchdog_match[] = {
>   	{ .compatible = "moxa,moxart-watchdog" },
>   	{ },
>   };
> +MODULE_DEVICE_TABLE(of, moxart_watchdog_match);
>
>   static struct platform_driver moxart_wdt_driver = {
>   	.probe      = moxart_wdt_probe,
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/