linux-kernel - Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 3 Sep 2015 09:48:03 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"J. German Rivera" <German.Rivera@...escale.com>
Cc:	arnd@...db.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, stuart.yoder@...escale.com,
	bhupesh.sharma@...escale.com, agraf@...e.de,
	bhamciu1@...escale.com, nir.erez@...escale.com,
	itai.katz@...escale.com, scottwood@...escale.com,
	R89243@...escale.com, dan.carpenter@...cle.com,
	richard.schmitt@...escale.com
Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> Since signatures of flib functions have changed, we had to
> change all the corresponding calls in the MC bus driver
> 
> Signed-off-by: J. German Rivera <German.Rivera@...escale.com>
> ---
>  drivers/staging/fsl-mc/bus/dpbp.c           | 232 ++++++++------
>  drivers/staging/fsl-mc/bus/dpmcp-cmd.h      |  81 +----
>  drivers/staging/fsl-mc/bus/dpmcp.c          | 123 +++++---
>  drivers/staging/fsl-mc/bus/dpmcp.h          | 123 +++++---
>  drivers/staging/fsl-mc/bus/dpmng.c          |  14 +-
>  drivers/staging/fsl-mc/bus/dprc-cmd.h       |   7 +-
>  drivers/staging/fsl-mc/bus/dprc-driver.c    |  61 +++-
>  drivers/staging/fsl-mc/bus/dprc.c           | 464 +++++++++++++++++++++++-----
>  drivers/staging/fsl-mc/bus/mc-allocator.c   | 122 ++++----
>  drivers/staging/fsl-mc/bus/mc-bus.c         |  72 +++--
>  drivers/staging/fsl-mc/bus/mc-sys.c         | 188 +++++++++--
>  drivers/staging/fsl-mc/include/dpbp-cmd.h   | 147 +++++++--
>  drivers/staging/fsl-mc/include/dpbp.h       |  91 ++++--
>  drivers/staging/fsl-mc/include/dpcon-cmd.h  | 159 ++++++++--
>  drivers/staging/fsl-mc/include/dpmng.h      |  14 +-
>  drivers/staging/fsl-mc/include/dprc.h       | 313 +++++++++++++++----
>  drivers/staging/fsl-mc/include/mc-cmd.h     |  28 +-
>  drivers/staging/fsl-mc/include/mc-private.h |  17 +-
>  drivers/staging/fsl-mc/include/mc-sys.h     |  51 ++-
>  19 files changed, 1661 insertions(+), 646 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c
> index d99ab6d..6857a67 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp.c
> +++ b/drivers/staging/fsl-mc/bus/dpbp.c
> @@ -1,48 +1,52 @@
> -/* Copyright 2013-2014 Freescale Semiconductor Inc.
> -*
> -* Redistribution and use in source and binary forms, with or without
> -* modification, are permitted provided that the following conditions are met:
> -* * Redistributions of source code must retain the above copyright
> -* notice, this list of conditions and the following disclaimer.
> -* * Redistributions in binary form must reproduce the above copyright
> -* notice, this list of conditions and the following disclaimer in the
> -* documentation and/or other materials provided with the distribution.
> -* * Neither the name of the above-listed copyright holders nor the
> -* names of any contributors may be used to endorse or promote products
> -* derived from this software without specific prior written permission.
> -*
> -*
> -* ALTERNATIVELY, this software may be distributed under the terms of the
> -* GNU General Public License ("GPL") as published by the Free Software
> -* Foundation, either version 2 of that License or (at your option) any
> -* later version.
> -*
> -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> -* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> -* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> -* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> -* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> -* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> -* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> -* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> -* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> -* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> -* POSSIBILITY OF SUCH DAMAGE.
> -*/
> +/* Copyright 2013-2015 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */

Changing the header of a file is not changing an API, please break this
up into logical pieces, this can't be taken as-is at all :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/