lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150903175006.GD19537@dtor-ws>
Date:	Thu, 3 Sep 2015 10:50:06 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Luis de Bethencourt <luis@...ethencourt.com>
Cc:	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Olivier Sobrie <olivier@...rie.be>,
	linux-input@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH v2 2/6] input: pwm-beeper: Fix module autoload for OF
 platform driver

On Sat, Aug 29, 2015 at 12:45:38PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>

Applied, thank you.

> ---
> 
> Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
> As suggested by Dmitry Torokhov.
> 
> Thanks,
> Luis
> 
>  drivers/input/misc/pwm-beeper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..f2261ab 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -173,6 +173,7 @@ static const struct of_device_id pwm_beeper_match[] = {
>  	{ .compatible = "pwm-beeper", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
>  #endif
>  
>  static struct platform_driver pwm_beeper_driver = {
> -- 
> 2.4.6
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ