linux-kernel - RE: Re: [PATCH 14/31] perf tools: Suppress probing messages when probing by BPF loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50399556C9727B4D88A595C8584AAB3752506338@GSjpTKYDCembx32.service.hitachi.net>
Date:	Thu, 3 Sep 2015 02:42:42 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Namhyung Kim'" <namhyung@...nel.org>,
	Wang Nan <wangnan0@...wei.com>
CC:	"acme@...hat.com" <acme@...hat.com>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"ast@...mgrid.com" <ast@...mgrid.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lizefan@...wei.com" <lizefan@...wei.com>,
	"pi3orama@....com" <pi3orama@....com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	"Daniel Borkmann" <daniel@...earbox.net>,
	David Ahern <dsahern@...il.com>, He Kuang <hekuang@...wei.com>,
	Jiri Olsa <jolsa@...nel.org>, Kaixu Xia <xiakaixu@...wei.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: RE: Re: [PATCH 14/31] perf tools: Suppress probing messages
 when probing by BPF loading

> From: Namhyung Kim [mailto:namhyung@...il.com] On Behalf Of Namhyung Kim
> 
> On Sat, Aug 29, 2015 at 04:21:48AM +0000, Wang Nan wrote:
> > This patch suppresses message output by add_perf_probe_events() and
> > del_perf_probe_events() if they are triggered by BPF loading. Before
> > this patch, when using 'perf record' with BPF object/source as event
> > selector, following message will be output:
> >
> >      Added new event:
> >            perf_bpf_probe:lock_page_ret (on __lock_page%return)
> >         You can now use it in all perf tools, such as:
> > 	            perf record -e perf_bpf_probe:lock_page_ret -aR sleep 1
> >      ...
> >      Removed event: perf_bpf_probe:lock_page_ret
> >
> > Which is misleading, especially 'use it in all perf tools' because they
> > will be removed after 'pref record' exit.
> >
> > In this patch, a 'silent' field is appended into probe_conf to control
> > output. bpf__{,un}probe() set it to true when calling
> > {add,del}_perf_probe_events().
> 
> I think that printing those messages should be done in cmd_probe()
> rather than add/del_perf_probe_events()..

Well... try to cleanup the messages. 

Thanks!

>