linux-kernel - Re: [PATCH] ARM: exynos_defconfig: Make S3C2410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Sep 2015 14:02:48 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Anand Moon <linux.amoon@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Andreas Faerber <afaerber@...e.de>,
	Lukasz Majewski <l.majewski@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable
 module

On 03.09.2015 13:10, Anand Moon wrote:
> S3C2410_WATCHDOG watchdog drivers should not be loaded automatically,
> but only if a watchdog daemon is installed.

First of all: why?

Secondly: even as a module driver could be loaded automatically to match
enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it
does not hurt - watchdog should be inactive:

s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq
disabled

Best regards,
Krzysztof

> 
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> ---
>  arch/arm/configs/exynos_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index aaf7aa4..b5d382e 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
>  CONFIG_THERMAL_EMULATION=y
>  CONFIG_EXYNOS_THERMAL=y
>  CONFIG_WATCHDOG=y
> -CONFIG_S3C2410_WATCHDOG=y
> +CONFIG_S3C2410_WATCHDOG=m
>  CONFIG_MFD_CROS_EC=y
>  CONFIG_MFD_CROS_EC_I2C=y
>  CONFIG_MFD_CROS_EC_SPI=y
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/