| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1441365759-7247-1-git-send-email-sudipm.mukherjee@gmail.com> Date: Fri, 4 Sep 2015 16:52:39 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Alasdair Kergon <agk@...hat.com>, Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com, Neil Brown <neilb@...e.com> Cc: linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org, Sudip Mukherjee <sudipm.mukherjee@...il.com> Subject: [PATCH] dm: ioctl: prevent double freeing DM_PARAMS_KMALLOC and DM_PARAMS_VMALLOC should never be set together in param_flags. We are setting these flags while allocating so we know that there is almost no chance of having these two set together but still we can have some additional safety. Signed-off-by: Sudip Mukherjee <sudip@...torindia.org> --- drivers/md/dm-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 80a4395..aaad74e 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -1680,7 +1680,7 @@ static void free_params(struct dm_ioctl *param, size_t param_size, int param_fla if (param_flags & DM_PARAMS_KMALLOC) kfree(param); - if (param_flags & DM_PARAMS_VMALLOC) + else if (param_flags & DM_PARAMS_VMALLOC) vfree(param); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists