linux-kernel - Re: [PATCH 1/3] mtd: spi-nor: Use write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD6G_RSoUcHP-VbR4AwAKhYXh56sFyc7MO0rS0q5QXS660pnZg@mail.gmail.com>
Date:	Fri, 4 Sep 2015 16:57:49 +0530
From:	Jagan Teki <jteki@...nedev.com>
To:	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jagan Teki <jteki@...nedev.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>
Subject: Re: [PATCH 1/3] mtd: spi-nor: Use write_sr for write status

On 19 August 2015 at 15:26, Jagan Teki <jteki@...nedev.com> wrote:
> Use existing write_sr() call instead of decoding and
> calling nor->write_reg separately.
>
> Signed-off-by: Jagan Teki <jteki@...nedev.com>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Brian Norris <computersforpeace@...il.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 47516d3..3e198b4 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -869,8 +869,7 @@ static int macronix_quad_enable(struct spi_nor *nor)
>         val = read_sr(nor);
>         write_enable(nor);
>
> -       nor->cmd_buf[0] = val | SR_QUAD_EN_MX;
> -       nor->write_reg(nor, SPINOR_OP_WRSR, nor->cmd_buf, 1, 0);
> +       write_sr(nor, val | SR_QUAD_EN_MX);
>
>         if (spi_nor_wait_till_ready(nor))
>                 return 1;
> --
> 1.9.1
>

Ping


-- 
Jagan | openedev.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/