linux-kernel - RE: [PATCH 5/5] perf probe: Print deleted events in cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50399556C9727B4D88A595C8584AAB375250D256@GSjpTKYDCembx32.service.hitachi.net>
Date:	Fri, 4 Sep 2015 11:46:45 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Namhyung Kim'" <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Wang Nan <wangnan0@...wei.com>,
	"pi3orama@....com" <pi3orama@....com>,
	sysp-manager <cti.systems-productivity-manager.ts@...achi.com>
Subject: RE: [PATCH 5/5] perf probe: Print deleted events in cmd_probe()

> From: Namhyung Kim [mailto:namhyung@...nel.org]
> 
> Showing actual trace event when deleteing perf events is only needed in
> perf probe command.  But the add functionality itself can be used by
> other places.  So move the printing code into the cmd_probe().
> 
> The output is not changed.
> 

OK, I just have a comment below.

> diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
> index 610f743671e1..d491cf69f91b 100644
> --- a/tools/perf/util/probe-event.h
> +++ b/tools/perf/util/probe-event.h
> @@ -144,6 +144,11 @@ extern int convert_perf_probe_events(struct perf_probe_event *pevs, int npevs);
>  extern int apply_perf_probe_events(struct perf_probe_event *pevs, int npevs);
>  extern void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs);
>  extern int del_perf_probe_events(struct strfilter *filter);
> +
> +extern int probe_file__get_events(int fd, struct strfilter *filter,
> +				  struct strlist *plist);
> +extern int probe_file__del_strlist(int fd, struct strlist *namelist);

These should be moved into probe-file.h.

> +
>  extern int show_perf_probe_event(const char *group, const char *event,
>  				 struct perf_probe_event *pev,
>  				 const char *module, bool use_stdout);

Thanks!