linux-kernel - Re: [BUG 4.2-rc8] Interrupt occurs while apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Sep 2015 14:02:38 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	"Richard W.M. Jones" <rjones@...hat.com>,
	Chuck Ebbert <cebbert.lkml@...il.com>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [BUG 4.2-rc8] Interrupt occurs while apply_alternatives() is
 patching the handler

On Thu, Sep 03, 2015 at 12:41:47PM +0200, Thomas Gleixner wrote:
> Nah. I rather put the local_irq_save into optimize_nops(). All other
> callers of add_nops() are operating on a buffer and use text_poke
> after that. Aside of that optimize_nops() is missing a sync_core().

Whoops.

> Updated patch below.

Looks good, thanks.

Hrrm, maybe optimize_nops() should work on a buffer and do
text_poke_early() too at the end, so that it doesn't differ from all the
other paths changing kernel text. So as to stuff like that doesn't get
missed next time I'm touching it.

But with your way we don't need the additional buffer. I guess your
solution is better resource-wise.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/