| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1441371393-15030-1-git-send-email-vkuznets@redhat.com> Date: Fri, 4 Sep 2015 14:56:33 +0200 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, James Bottomley <JBottomley@...n.com>, linux-kernel@...r.kernel.org, "K. Y. Srinivasan" <kys@...rosoft.com> Subject: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The problem is that if size == 0 when we start calculating sf_cap this loop will never end. The caller causing the issue is sd_read_capacity(), the problem was noticed on Hyper-V. Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com> --- lib/string_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/string_helpers.c b/lib/string_helpers.c index c98ae81..a155c7b 100644 --- a/lib/string_helpers.c +++ b/lib/string_helpers.c @@ -76,7 +76,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, i++; } - sf_cap = size; + sf_cap = size ? size : 1; for (j = 0; sf_cap*10 < 1000; j++) sf_cap *= 10; -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists