linux-kernel - Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Sep 2015 15:35:22 +0200
From:	Lars Persson <lars.persson@...s.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend
 on HAS_DMA

On Fri, 2015-09-04 at 14:44 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_map_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Lars Persson <larper@...s.com>

> ---
>  drivers/net/ethernet/synopsys/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/synopsys/Kconfig b/drivers/net/ethernet/synopsys/Kconfig
> index a8f315106742d9b1..8276ee5a7d541b2e 100644
> --- a/drivers/net/ethernet/synopsys/Kconfig
> +++ b/drivers/net/ethernet/synopsys/Kconfig
> @@ -20,7 +20,7 @@ config SYNOPSYS_DWC_ETH_QOS
>  	select PHYLIB
>  	select CRC32
>  	select MII
> -	depends on OF
> +	depends on OF && HAS_DMA
>  	---help---
>  	  This driver supports the DWC Ethernet QoS from Synopsys
>  



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/