linux-kernel - Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1441338006.9666.38.camel@perches.com>
Date:	Thu, 03 Sep 2015 20:40:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alexey Klimov <alexey.klimov@...aro.org>
Cc:	daniel.lezcano@...aro.org, linux-mediatek@...ts.infradead.org,
	matthias.bgg@...il.com, yingjoe.chen@...iatek.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	klimov.linux@...il.com
Subject: Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to
 pr_err()s in mtk_timer_init

On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote:
> These messages are actually errors and not warnings.
> Use pr_err() macro for them and add missing \n.
[]
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
[]
> @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node)
>  
>  	evt = kzalloc(sizeof(*evt), GFP_KERNEL);
>  	if (!evt) {
> -		pr_warn("Can't allocate mtk clock event driver struct");
> +		pr_err("Can't allocate mtk clock event driver struct\n");
>  		return;
>  	}

Might as well remove this one as there's
a generic stack_dump() on alloc failures.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/