| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1441385118-27199-1-git-send-email-sasha.levin@oracle.com> Date: Fri, 4 Sep 2015 12:45:18 -0400 From: Sasha Levin <sasha.levin@...cle.com> To: rostedt@...dmis.org, mingo@...hat.com Cc: axboe@...com, tj@...nel.org, linux-kernel@...r.kernel.org, Sasha Levin <sasha.levin@...cle.com> Subject: [PATCH] writeback: verify that underlying dev exists before getting its name We can't assume there is always an underlying device and must verify that as well. Otherwise, we'd deref a NULL ptr here. Signed-off-by: Sasha Levin <sasha.levin@...cle.com> --- include/trace/events/writeback.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index fff846b..8f9efaa 100644 --- a/include/trace/events/writeback.h +++ b/include/trace/events/writeback.h @@ -66,7 +66,9 @@ TRACE_EVENT(writeback_dirty_page, TP_fast_assign( strncpy(__entry->name, - mapping ? dev_name(inode_to_bdi(mapping->host)->dev) : "(unknown)", 32); + mapping && inode_to_bdi(mapping->host)->dev ? + dev_name(inode_to_bdi(mapping->host)->dev) : + "(unknown)", 32); __entry->ino = mapping ? mapping->host->i_ino : 0; __entry->index = page->index; ), -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists