linux-kernel - RE: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Sep 2015 17:48:55 +0000
From:	Jose Rivera <German.Rivera@...escale.com>
To:	Nayeemahmed Badebade <itachi.opsrc@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	Stuart Yoder <stuart.yoder@...escale.com>,
	"agraf@...e.de" <agraf@...e.de>,
	"hgujulan@...teon.com" <hgujulan@...teon.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

> -----Original Message-----
> From: Nayeemahmed Badebade [mailto:itachi.opsrc@...il.com]
> Sent: Friday, September 04, 2015 12:01 PM
> To: gregkh@...uxfoundation.org
> Cc: Rivera Jose-B46482; Yoder Stuart-B08248; agraf@...e.de;
> hgujulan@...teon.com; linux-kernel@...r.kernel.org
> Subject: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
> 
> Fixed coding style issues where kernel types u16,u64,u32 should be
> preferred over uint16_t,uint64_t,uint32_t
> 
Nayeemahmed,

Thanks for your interests in helping us clean up this coding style issue.
However, doing this for all the files related to the MC bus driver (not just
for one) is something that I intend to do in a future patch as
part of the "Cleanup" item of our TODO list.
Doing this clean up across the board for all files is preferable than 
doing it just for this file in this patch.
Thanks,

German

> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@...il.com>
> ---
>  drivers/staging/fsl-mc/bus/mc-bus.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-
> mc/bus/mc-bus.c
> index 766a659..b3a60a0 100644
> --- a/drivers/staging/fsl-mc/bus/mc-bus.c
> +++ b/drivers/staging/fsl-mc/bus/mc-bus.c
> @@ -209,7 +209,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
>  static int get_dprc_icid(struct fsl_mc_io *mc_io,
>  			 int container_id, uint16_t *icid)
>  {
> -	uint16_t dprc_handle;
> +	u16 dprc_handle;
>  	struct dprc_attributes attr;
>  	int error;
> 
> @@ -234,7 +234,7 @@ common_cleanup:
>  	return error;
>  }
> 
> -static int translate_mc_addr(uint64_t mc_addr, phys_addr_t *phys_addr)
> +static int translate_mc_addr(u64 mc_addr, phys_addr_t *phys_addr)
>  {
>  	int i;
>  	struct fsl_mc *mc = dev_get_drvdata(fsl_mc_bus_type.dev_root-
> >parent);
> @@ -600,7 +600,7 @@ static int fsl_mc_bus_probe(struct platform_device
> *pdev)
>  	struct fsl_mc_io *mc_io = NULL;
>  	int container_id;
>  	phys_addr_t mc_portal_phys_addr;
> -	uint32_t mc_portal_size;
> +	u32 mc_portal_size;
>  	struct mc_version mc_version;
>  	struct resource res;
> 
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/