linux-kernel - RE: [PATCH] csiostor:Fix locking issues in the function csio_scsim_cleanup_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <525DB349B3FB5444AE057A887CB2A8D893E435CB@nice.asicdesigners.com>
Date:	Fri, 4 Sep 2015 20:45:18 +0000
From:	Anish Bhatt <anish@...lsio.com>
To:	Praveen Madhavan <praveenm@...lsio.com>,
	Nicholas Krause <xerofoify@...il.com>,
	"JBottomley@...n.com" <JBottomley@...n.com>
CC:	"hare@...e.de" <hare@...e.de>,
	"michaelc@...wisc.edu" <michaelc@...wisc.edu>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Hariprasad S <hariprasad@...lsio.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] csiostor:Fix locking issues in the function
 csio_scsim_cleanup_io_lnode



> -----Original Message-----
> From: Praveen Madhavan
> Sent: Friday, September 4, 2015 6:12 AM
> To: Anish Bhatt; Nicholas Krause; JBottomley@...n.com
> Cc: hare@...e.de; michaelc@...wisc.edu; davem@...emloft.net;
> Hariprasad S; linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] csiostor:Fix locking issues in the function
> csio_scsim_cleanup_io_lnode
> 
> csio_scsim_cleanup_io_lnode always called with spin_lock_irq held.
> Please refer:
> csio_attr.c:624:        csio_scsim_cleanup_io_lnode(csio_hw_to_scsim(hw),
> ln);
> csio_attr.c:649:
> csio_scsim_cleanup_io_lnode(csio_hw_to_scsim(hw), ln);
> 
> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> owner@...r.kernel.org] On Behalf Of Anish Bhatt
> Sent: Thursday, September 03, 2015 7:07 AM
> To: Nicholas Krause; JBottomley@...n.com
> Cc: hare@...e.de; michaelc@...wisc.edu; davem@...emloft.net;
> Hariprasad S; linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] csiostor:Fix locking issues in the function
> csio_scsim_cleanup_io_lnode
> 
> > -----Original Message-----
> > From: Nicholas Krause [mailto:xerofoify@...il.com]
> > Sent: Wednesday, September 2, 2015 10:36 AM
> > To: JBottomley@...n.com
> > Cc: hare@...e.de; michaelc@...wisc.edu; davem@...emloft.net; Anish
> > Bhatt; Hariprasad S; linux-scsi@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: [PATCH] csiostor:Fix locking issues in the function
> > csio_scsim_cleanup_io_lnode
> >
> > This fixes locking issues in the function csio_scsim_cleanup_io_lnode
> > by locking around the call to the function csio_csci_gather_active_ios
> > with the function pair spin_lock_irq/spin_unlock_irq as any function
> > calling this particular function must do in order to avoid concurrent
> > threads of execution on the passed structure pointer of type csio_hw
> > as this structure pointer can be shared across mutliple threads in the
> kernel.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> > ---
> >  drivers/scsi/csiostor/csio_scsi.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/scsi/csiostor/csio_scsi.c
> > b/drivers/scsi/csiostor/csio_scsi.c
> > index 2c4562d..c318855 100644
> > --- a/drivers/scsi/csiostor/csio_scsi.c
> > +++ b/drivers/scsi/csiostor/csio_scsi.c
> > @@ -1327,7 +1327,9 @@ csio_scsim_cleanup_io_lnode(struct csio_scsim
> > *scm, struct csio_lnode *ln)
> >  	sld.level = CSIO_LEV_LNODE;
> >  	sld.lnode = ln;
> >  	INIT_LIST_HEAD(&ln->cmpl_q);
> > +	spin_lock_irq(&hw->lock);
> >  	csio_scsi_gather_active_ios(scm, &sld, &ln->cmpl_q);
> > +	spin_unlock_irq(&hw->lock);
> >
> >  	/* No I/Os pending on this lnode  */
> >  	if (list_empty(&ln->cmpl_q))
> > --
> > 2.1.4
> 
> Acked-By:  Anish Bhatt <anish@...lsio.com>

My bad, NACK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/