linux-kernel - RE: [PATCH] csiostor:Fix backwards locking in the function __csio_unreg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <525DB349B3FB5444AE057A887CB2A8D893E43743@nice.asicdesigners.com>
Date:	Fri, 4 Sep 2015 22:44:17 +0000
From:	Anish Bhatt <anish@...lsio.com>
To:	Nicholas Krause <xerofoify@...il.com>,
	"JBottomley@...n.com" <JBottomley@...n.com>,
	Praveen Madhavan <praveenm@...lsio.com>
CC:	"hare@...e.de" <hare@...e.de>,
	"michaelc@...wisc.edu" <michaelc@...wisc.edu>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Hariprasad S <hariprasad@...lsio.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] csiostor:Fix backwards locking in the function
 __csio_unreg_rnode


> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Thursday, September 3, 2015 10:09 AM
> To: JBottomley@...n.com
> Cc: hare@...e.de; michaelc@...wisc.edu; davem@...emloft.net; Anish
> Bhatt; Hariprasad S; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] csiostor:Fix backwards locking in the function
> __csio_unreg_rnode
> 
> This fixes backwards locking in the function __csio_unreg_rnode to properly
> lock before the call to the function csio_unreg_rnode and not unlock with
> spin_unlock_irq as this would not allow the proper protection for concurrent
> access on the shared csio_hw structure pointer hw. In addition switch the
> locking after the critical region function call to properly unlock instead with
> spin_unlock_irq on the shared structure pointer.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/scsi/csiostor/csio_rnode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/csiostor/csio_rnode.c
> b/drivers/scsi/csiostor/csio_rnode.c
> index e9c3b04..029a09e 100644
> --- a/drivers/scsi/csiostor/csio_rnode.c
> +++ b/drivers/scsi/csiostor/csio_rnode.c
> @@ -580,9 +580,9 @@ __csio_unreg_rnode(struct csio_rnode *rn)
>  		ln->last_scan_ntgts--;
>  	}
> 
> -	spin_unlock_irq(&hw->lock);
> -	csio_unreg_rnode(rn);
>  	spin_lock_irq(&hw->lock);
> +	csio_unreg_rnode(rn);
> +	spin_unlock_irq(&hw->lock);
> 
>  	/* Cleanup I/Os that were waiting for rnode to unregister */
>  	if (cmpl)
> --
> 2.1.4

NACK, function is called with lock held.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/