linux-kernel - Re: [PATCH] gpio: gpiolib: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 5 Sep 2015 21:32:52 +0800
From:	Peng Fan <van.freenix@...il.com>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: gpiolib: use devm_* API to simplify driver code

On Tue, Aug 25, 2015 at 11:38:47AM +0300, Grygorii Strashko wrote:
> On 08/24/2015 03:05 PM, Peng Fan wrote:
> >Use devm_* API to simplify driver code.
> >
> >Signed-off-by: Peng Fan <van.freenix@...il.com>
> >Cc: Linus Walleij <linus.walleij@...aro.org>
> >Cc: Alexandre Courbot <gnurou@...il.com>
>  ---
> >  drivers/gpio/gpiolib.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> >diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> >index 6bc612b..f9470b0 100644
> >--- a/drivers/gpio/gpiolib.c
> >+++ b/drivers/gpio/gpiolib.c
> >@@ -243,7 +243,8 @@ int gpiochip_add(struct gpio_chip *chip)
> >  	int		base = chip->base;
> >  	struct gpio_desc *descs;
> >
> >-	descs = kcalloc(chip->ngpio, sizeof(descs[0]), GFP_KERNEL);
> >+	descs = devm_kcalloc(chip->dev, chip->ngpio, sizeof(descs[0]),
> >+			     GFP_KERNEL);
> 
> ^ above will not work for every one as NOT all GPIO drivers
> implemented using dev/drv model, so chip->dev could be not set
> (at least it was true when I've checked it last time).
> 

Thanks for correcting me!

Regards,
Peng.

> 
> 
> 
> -- 
> regards,
> -grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/