linux-kernel - Re: [RFC v1 0/4] iio: new chemical sensor framework and channel types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55EB106F.8040401@kernel.org>
Date:	Sat, 5 Sep 2015 16:55:27 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Daniel Baluta <daniel.baluta@...il.com>,
	Matt Ranostay <mranostay@...il.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v1 0/4] iio: new chemical sensor framework and channel types

On 05/09/15 09:20, Daniel Baluta wrote:
> On Sat, Sep 5, 2015 at 8:53 AM, Matt Ranostay <mranostay@...il.com> wrote:
>> Initial RFC for new chemical sensor framework, IIO_CONCENTRATION,
>> and IIO_RESISTANCE channel types.
>>
>> Important notes:
>> * Not been tested on real hardware yet but that isn't the main RFC reason and
>>   once hardware is in hand it will be verified
>> * Reason the IIO_CONCENTRATION type isn't in percent but has modifiers for ppm
>>   and ppb is the scale value for the latter would cause a integer overflow
>>   using IIO_VAL_FRACTIONAL
Then add a a return type that deals with that issue.
Perhaps IIO_VAL_FRACTIONAL_DIVMILLION or
something like that.  Will just do the normal calculation but when outputting
append a load of leading zeros.  So val/(val2 * 1000000) = (val/val2) / 1000000
so decimal shift right 6 digits.
> 
> Please add this details also in the commit message introducing
> IIO_CONCENTRATION. Readers
> will faster find commit messages than cover letter.
Indeed, I wouldn't even have read the cover letter (tend to like jumping in the
deep end ;) except that I wondered what Daniel was commenting on!
> 
> Interesting patches Matt! :)
Indeed!
> 
> thanks,
> Daniel.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/