linux-kernel - Re: [PATCH v3 1/5] input: touchscreen: add imx6ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150905185308.GC18006@dtor-ws>
Date:	Sat, 5 Sep 2015 11:53:08 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Haibo Chen <haibo.chen@...escale.com>
Cc:	shawnguo@...nel.org, kernel@...gutronix.de, linux@....linux.org.uk,
	ijc+devicetree@...lion.org.uk, mark.rutland@....com,
	pawel.moll@....com, robh+dt@...nel.org, mpa@...gutronix.de,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v3 1/5] input: touchscreen: add imx6ul_tsc driver support

On Fri, Aug 28, 2015 at 05:09:32PM +0800, Haibo Chen wrote:
> Freescale i.MX6UL contains a internal touchscreen controller,
> this patch add a driver to support this controller.
> 
> Signed-off-by: Haibo Chen <haibo.chen@...escale.com>

Merged #1 and #2 and applied, thank you.

Also:

> +		/*
> +		 * Delay some time(max 2ms), wait the pre-charge done.
> +		 * After the pre-change mode, TSC go into detect mode.
> +		 * And in detect mode, we can get the xnur gpio value.
> +		 * If xnur is high, this means the touch screen still
> +		 * be touched. If xnur is low, this means finger leave
> +		 * the touch screen.
> +		 */
> +		timeout = jiffies + HZ/500;

I do not think that would quite work with HZ < 500. I changed this to

		timeout = jiffies + msecs_to_jiffies(2);

and also moved this block into a separate function.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/