linux-kernel - Re: [PATCH v2 10/17] staging: sm750fb: ddk750_swi2c: rename CamelCase static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150905190316.GC11445@zed>
Date:	Sat, 5 Sep 2015 22:03:16 +0300
From:	Mike Rapoport <mike.rapoport@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	Sudip Mukherjee <sudip@...torindia.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 10/17] staging: sm750fb: ddk750_swi2c: rename
 CamelCase static functions

On Fri, Sep 04, 2015 at 05:56:07PM +0530, Sudip Mukherjee wrote:
> On Fri, Sep 04, 2015 at 11:18:55AM +0300, Mike Rapoport wrote:
> > Fix the checkpatch warning about CamelCase.
> > 
> > Signed-off-by: Mike Rapoport <mike.rapoport@...il.com>
> > ---
> This is again having too many renames. I lost track while seeing. :(
> Like Greg said, please break them into separate patches.

Maybe I've missed something, but I only remember that Greg asked not to
add sm750_ prefix to the static functions.
I beleive, that 58 changes is not too many, and it still falls under defintion
of "single logical change". IMHO, splitting this patch and, e.g.,
renaming a function at a time won't do better
 
> regards
> sudip

--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/