| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150905194755.GD6040@lunn.ch> Date: Sat, 5 Sep 2015 21:47:55 +0200 From: Andrew Lunn <andrew@...n.ch> To: Michael Welling <mwelling@...e.org> Cc: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: phy: Handle postive return codes in phy_connect On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > > > The function phy_connect_direct can possibly return a positive > > > return code. Using ERR_PTR with a positive value can lead to > > > deferencing of an invalid pointer. > > > > Is this the correct fix? Would it not be better to find where the > > positive return code is from and fix that? > > I guess I can trace it back to find out where the positive return code > is originating. > > Is phy_connect_direct always supposed to return valid -errno? I would look at this from a different angle. A positive ERRNO is probably a bug of some sort. So rather than papering over the cracks, go find what the real issue is. It might not be an ERRNO. E.g. https://lkml.org/lkml/2015/9/3/534 fixed a bug where a positive value is returned which is not an indication of an error. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists