linux-kernel - Re: [PATCH] kvm: compile process_smi_save_seg_64() only for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55EC4C28.6070705@redhat.com>
Date:	Sun, 6 Sep 2015 16:22:32 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>,
	Gleb Natapov <gleb@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: compile process_smi_save_seg_64() only for x86_64



On 06/09/2015 15:35, Alexander Kuleshov wrote:
> The process_smi_save_seg_64() function called only in the
> process_smi_save_state_64() if the CONFIG_X86_64 is set. This
> patch adds #ifdef CONFIG_X86_64 around process_smi_save_seg_64()
> to prevent following warning message:
> 
> arch/x86/kvm/x86.c:5946:13: warning: ‘process_smi_save_seg_64’ defined but not used [-Wunused-function]
>  static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
>              ^
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/kvm/x86.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 1e7e76e..a60bdbc 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5943,6 +5943,7 @@ static void process_smi_save_seg_32(struct kvm_vcpu *vcpu, char *buf, int n)
>  	put_smstate(u32, buf, offset, process_smi_get_segment_flags(&seg));
>  }
>  
> +#ifdef CONFIG_X86_64
>  static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
>  {
>  	struct kvm_segment seg;
> @@ -5958,6 +5959,7 @@ static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
>  	put_smstate(u32, buf, offset + 4, seg.limit);
>  	put_smstate(u64, buf, offset + 8, seg.base);
>  }
> +#endif
>  
>  static void process_smi_save_state_32(struct kvm_vcpu *vcpu, char *buf)
>  {
> 

Applied, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/