lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 Sep 2015 08:51:54 -0700 From: Joe Perches <joe@...ches.com> To: Nick Warne <nick@...icks.net> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Alexey Kodanev <alexey.kodanev@...cle.com> Subject: Re: [PATCH] net/core/sysctl_net_core.c unused variable On Sun, 2015-09-06 at 16:36 +0100, Nick Warne wrote: > On 06/09/15 16:28, Joe Perches wrote: > > On Sun, 2015-09-06 at 16:16 +0100, Nick Warne wrote: > >> On 06/09/15 15:52, Joe Perches wrote: > >> > On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: > >> >> gcc version 4.8.2 (GCC) warns that 'static int one = 1;' is declared but > >> >> not used in file net/core/sysctl_net_core.c. > >> > > >> > Only when CONFIG_NET isn't set. > >> > >> CONFIG_NET=y > >> > >> Peculiar indeed. > >> > >> >> Reading the file, that is > >> >> the case. Attached is a patch to remove it. > >> > > >> > $ git grep -w -n one net/core/sysctl_net_core.c > >> > net/core/sysctl_net_core.c:26:static int one = 1; > >> > net/core/sysctl_net_core.c:332: .extra2 = &one > >> > > >> >> Signed-off-by: Nick Warne <nick@...icks.net> > >> > > >> > Please use grep to augment reading. > >> > >> grep -w -n one net/core/sysctl_net_core.c > >> 26:static int one = 1; > >> > >> ? > >> > >> I just don't have the &one. > >> > >> I am confused now. > > > > What source tree are you using? > > Latest longterm 3.18.21 OK, it's important to mention that otherwise the assumption would be a git tree like net or net-next. > > What changes in what branch exist? > > I am not using git (if that is what you mean by 'branches') - just > tarballs from kernel.org (OK, using git and linux-stable) $ git grep -w -n one v3.18.21 -- net/core/sysctl_net_core.c v3.18.21:net/core/sysctl_net_core.c:26:static int one = 1; And the responsible commit: commit c48cf4f27d4555a455c3fef71137bd0fc44d1656 ("net: sysctl_net_core: check SNDBUF and RCVBUF for min length") -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists